lsp-format-region: Fix error "no region" #4827
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't that the expected behaviour? 🤔 |
|
@jcs090218 |
jcs090218
reviewed
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lsp-format-regionwill emit error messageThe mark is not set now, so there is no regionat the very beginning.It can be reproduced with follow steps:
Start the Emacs with lsp, and open a c++ file
/tmp/a.cpp, and executelsp-format-region, then got the error message.To workaround the issue, just select one char/word and de-select the region, then execute the
lsp-format-region.This PR will follow the document of
lsp-format-regiondescription to accept region or line.Please help review and approve this change, thanks